[Webkit-unassigned] [Bug 15449] [CAIRO] SVG gradients do not work properly

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15449


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20593|review?                     |review-
               Flag|                            |




------- Comment #7 from eric at webkit.org  2008-04-16 21:41 PDT -------
(From update of attachment 20593)
The patch in general looks fine.

We don't generally pre-declare variables at the top of a block.  That's C-style
and this is C++.
double cx, fx, cy, fy, radius, fradius; // one example

These are extra braces according to our style guidelines:
if ((fx + cx) <  cx) {
+                fx = int(cos(angle) * radius) + 1;
+            }

Otherwise it looks fine.

Why are there no test changes?  Does the GTK build still not have pixel tests?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.