[Webkit-unassigned] [Bug 10794] [CSS1] Background-attachment: scroll should scroll within the containing block

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=10794


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20557|review?                     |review-
               Flag|                            |




------- Comment #13 from hyatt at apple.com  2008-04-15 10:51 PDT -------
(From update of attachment 20557)
- h = bg->imageSize(style()->effectiveZoom()).height() * scaledWidth /
bg->imageSize(style()->effectiveZoom()).width();
+ h = bg->imageSize(style()->effectiveZoom()).height() * w /
bg->imageSize(style()->effectiveZoom()).width();

This change fixes computation of height, but isn't the corresponding width case
also broken?  You could adjust the background-size computation so that it
computes values of w and h first (for fixed/percent).  Then handle the auto
cases for each after that.  (That enables you to fix the width case also.)

So instead of 

if (width is fixed)
else if (width is percent)
else if (width is auto)

if (height is fixed)
else if (height is percent)
else if (height is auto)

you could do:

if (width is fixed)
else if (width is percent)

if (height is fixed)
else if (height is percent)

if (width is auto && !height is auto)
else if (!width is auto && height is auto)
else if (width and height both auto)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.