[Webkit-unassigned] [Bug 10794] [CSS1] Background-attachment: scroll should scroll within the containing block

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=10794


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20542|review?                     |review-
               Flag|                            |




------- Comment #9 from hyatt at apple.com  2008-04-14 20:50 PDT -------
(From update of attachment 20542)
This is on the right track.  Thanks for contributing.  Comments below:

background-size and background-position are both supposed to be computed using
the box specified by background-origin.  This is CSS3 stuff so that may not
really be obvious yet, but that's how it is supposed to work.

Your check for background-position is correct.  However background-size is now
taking rather funny values, since it could end up being the viewport's
width/height - margins.  background-size should be using the same width and
height you're passing to background-position.

The destination rect for fixed backgrounds is also being potentially messed up
by your modifications to make left/right non-zero.  For example:

cw = pw + left + right;

Now that you put margins into left/right, the destination rect for fixed
backgrounds will be too small.

Style nitpick: Put spaces between arithmetic expressions, e.g.,

height() + marginTop() + marginBottom()

and not

height()+marginTop()+marginBottom().


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.