[Webkit-unassigned] [Bug 18473] Animation <use> fixes

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18473





------- Comment #7 from koivisto at iki.fi  2008-04-14 16:11 PDT -------
(In reply to comment #4)

> Is gElementsWithInstanceUpdatesBlocked the official pattern now? I thought s_
> was?

s_ is for static member variables only.

> needs a comment as to why RefPtr<Node> is not required to protect against
> MutationEvent listeners doing bad things.

The subtree is not in document so mutation events won't happen. Added assert
and comment.

Generally using RefPtr<> in this kind of places is bad idea since it is a)
slow, b) hides bugs.

> 
> +bool SVGSMILElement::isSMILElement(Node* node)
> I'm surprised that's even needed.  I guess I would have figured there would
> have been a virtual bool isSVGSMILElement() const { return false; } on
> SVGElement.

That might be good to add as well, but this kind of interface has advantage of
being usable without casting for Node*'s.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.