[Webkit-unassigned] [Bug 18473] Animation <use> fixes

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18473


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20522|review?                     |review-
               Flag|                            |




------- Comment #4 from eric at webkit.org  2008-04-14 13:56 PDT -------
(From update of attachment 20522)
I prefer arguments to have more informative names than "b":
setInstanceUpdatesBlocked
"blockUpdates" perhaps?

Is gElementsWithInstanceUpdatesBlocked the official pattern now? I thought s_
was?

 void SVGUseElement::removeDisallowedElementsFromSubtree(Node* element)

needs a comment as to why RefPtr<Node> is not required to protect against
MutationEvent listeners doing bad things.

+bool SVGSMILElement::isSMILElement(Node* node)
I'm surprised that's even needed.  I guess I would have figured there would
have been a virtual bool isSVGSMILElement() const { return false; } on
SVGElement.

r- due to the possible crasher due to mutation events (or lack of comment)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.