[Webkit-unassigned] [Bug 17952] Add "--cairo" flag to 'build-webkit' command

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17952


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20445|review?                     |review-
               Flag|                            |




------- Comment #6 from aroben at apple.com  2008-04-14 08:27 PDT -------
(From update of attachment 20445)
+    my $isCairo = grep(/^--cairo$/i, @ARGV);
+
     for my $i (0 .. $#ARGV) {
         my $opt = $ARGV[$i];
         if ($opt =~ /^--debug$/i || $opt =~ /^--devel/i) {
             splice(@ARGV, $i, 1);
             $passedConfiguration = "Debug";
+            $passedConfiguration .= "_Cairo" if $isCairo;
             return;
         }
         if ($opt =~ /^--release$/i || $opt =~ /^--deploy/i) {
             splice(@ARGV, $i, 1);
             $passedConfiguration = "Release";
+            $passedConfiguration .= "_Cairo" if $isCairo;
             return;
         }

This seems very Windows-specific, since only the Windows .vcproj files have
these _Cairo configurations. Perhaps the flag should only have an effect on
Windows? Perhaps it should be named something more specific, like
--cairo-win32?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.