[Webkit-unassigned] [Bug 18468] Cairo build does not work with CURL

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18468


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20512|review?                     |review-
               Flag|                            |




------- Comment #2 from aroben at apple.com  2008-04-14 08:02 PDT -------
(From update of attachment 20512)
+#if PLATFORM(CF)
+#include <CoreFoundation/CoreFoundation.h>
+#include <WebKitSystemInterface/WebKitSystemInterface.h>
+#endif

Can you explain why these changes are needed? In particular I don't see a
reason to ever include WebKitSystemInterface.h in another header file, since
WebKitSystemInterface.h only declares functions, not types. Can we move these
#includes to the source files that require them? If they're needed by this
header, can we replace them with the appropriate forward declarations?

+++ WebCore/platform/network/curl/ResourceHandleCurl.cpp        (working copy)
@@ -176,4 +176,11 @@ void ResourceHandle::loadResourceSynchro
     response = syncLoader.resourceResponse();
 }

+//stubs needed for windows version
+void ResourceHandle::didReceiveAuthenticationChallenge(const
AuthenticationChallenge&) {notImplemented();};
+void ResourceHandle::receivedCredential(const AuthenticationChallenge&, const
Credential&) {notImplemented();};
+void ResourceHandle::receivedRequestToContinueWithoutCredential(const
AuthenticationChallenge&) {notImplemented();};
+void ResourceHandle::receivedCancellation(const
AuthenticationChallenge&){notImplemented();};
+
+

Even though these are just stubs I think you should format them correctly. That
way it'll be easier to see the changes when someone does implement them.

+++ WebKit/win/WebError.h       (working copy)
@@ -28,6 +28,8 @@

 #include "WebKit.h"

+#include <wtf/RetainPtr.h>
+

This #include should follow the WebCore #includes, to keep things in
lexicographical order.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.