[Webkit-unassigned] [Bug 13097] Unsupported content:inherit value

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13097


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20372|review?                     |review-
               Flag|                            |




------- Comment #6 from darin at apple.com  2008-04-12 23:29 PDT -------
(From update of attachment 20372)
Thanks for taking this on. Looks like a good first cut.

A few things need fixing.

If you're going to implement inherit, then you need to remove the following
now-inaccurate comment:

         // FIXME: In CSS3, it will be possible to inherit content.  In CSS2 it
is not.  This
         // note is a reminder that eventually "inherit" needs to be supported.

And replace it with a new one.

+/*                    case CONTENT_QUOTE:
+                        m_style->setContent(content->m_content.m_quote);
+                        break;*/

We don't check in commented-out code like this in the WebKit project.

The test case is inadequate. For example, it doesn't exercise the
CONTENT_OBJECT or CONTENT_COUNTER cases in the newly-added switch statement.
The only type of inheritance it checks is inheriting nothing.

Also, are we guaranteed that m_parentStyle is non-0? I think you could probably
create a test case where content: inherit is in a style without a parent, and
then we'd dereference null in the inherit code.

review- because of these issues.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.