[Webkit-unassigned] [Bug 18401] New: Apparent caching between form submits 2

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18401

           Summary: Apparent caching between form submits 2
           Product: WebKit
           Version: 523.x (Safari 3)
          Platform: All
               URL: http://demo.maconomy.com
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P1
         Component: History
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: pen at maconomy.dk


Some values in a form is apparently cached after submit and when we submit a
new form the previous values are shown in the new form.

When we navigate away and thereby submit the framed form (Picture 1) 
we go to Picture 2. The form in picture 2 contains the same values 
as the framed form in Picture 1.

Steps to Reproduce:
1. Set your user agent to "Safari 2.0.4"
2.
http://193.17.206.202/cgi-bin/Maconomy/MaconomyPortal.mas11.W_MAS/Framework/maconomyportal.msc
3. Login as "Kevin Sullivan" password 123456
4. Click "Job Management" -> "My Jobs" -> Job no:  2010001
5. navigate between the tabs and see that the values from the previous form are
briefly shown before the real data.

A more simple alternative is:
1. Open "Job Management" -> "New Job"
2. Select an element in the drop down.
3. Click next.
4. The element you selected in the dropdown is brifly shown in the
"Client/Brand" field

Expected Results:
On previous versions of Safari and Firefox and IE the form 
would not contain any values. e.g no values are "copied"/cached 
between the two forms.

Actual Results:
Explain what actually occurred when steps above are executed.

Regression:
This worked in Safari 2 on Panther and Tiger

I found that r25410 introduces the problem. The code that causes the problem is
shown below in snippet 1. If I reuse addHistoryForCurrentLocation I dont see
the problem, but it of course introduces other problems (as mentioned in the
code - 5333496).

I did the test in r29336

FrameLoader.cpp

Snippet 1:
    if (!frameNavigationOnLoad && !documentLoader()->isClientRedirect()) {
        if (!documentLoader()->urlForHistory().isEmpty())
            addHistoryForCurrentLocation();
    } else if (documentLoader()->unreachableURL().isEmpty() &&
m_currentHistoryItem) {
        m_currentHistoryItem->setURL(documentLoader()->url());
       
m_currentHistoryItem->setFormInfoFromRequest(documentLoader()->request());
    }

Snippet 2:
    if (!frameNavigationOnLoad && !documentLoader()->isClientRedirect()) {
        if (!documentLoader()->urlForHistory().isEmpty())
            addHistoryForCurrentLocation();
    } else if (documentLoader()->unreachableURL().isEmpty() &&
m_currentHistoryItem) {
//        m_currentHistoryItem->setURL(documentLoader()->url());
//      
m_currentHistoryItem->setFormInfoFromRequest(documentLoader()->request());
            addHistoryForCurrentLocation();
    }


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.