[Webkit-unassigned] [Bug 18375] Make SVG animation work

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18375


koivisto at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oliver at apple.com




------- Comment #7 from koivisto at iki.fi  2008-04-09 13:41 PDT -------
(In reply to comment #3)
> In +void SVGAnimateElement::applyAnimatedValueToElement(unsigned repeat)
> 
> "valueToApple" seems like it may be a tyop :D

Lol, fixed.

> I suspect parseNumberValueAndUnit will parse "100 px/%" etc which seems bogus

Added check for that.

> Adding commented out code in SVGAnimateMotionElement::parseMappedAttributes
> seems like an accident, and isn't commented itself so i have no idea why :(

Replaced with comment.

> Tyop in m_baseIndexInTranformList -- missing 's'

Fixed.

> Are you sure about the comment in SVGElement::updateStyleAttributeIfNeeded?
> i've seen plenty of examples of people using "style" attributes in svg, it
> seems odd for it to not be accessible form the dom...

Yeah, that was a bad idea Reverted that part.

> I'm not happy with doubleSort/sortTimeList.  doubleSort makes an assumption
> that each m_beginTime will always be the first member of SMILTime which seems
> really icky...

Yeah, that was cheesy. A leftover from before I switched to SMILTime, now
fixed.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.