[Webkit-unassigned] [Bug 18375] Make SVG animation work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 8 22:56:44 PDT 2008


------- Comment #3 from oliver at apple.com  2008-04-08 22:56 PDT -------
(From update of attachment 20419)
First run through it (feel to tired for a full review atm :( ), it looks mostly
fine, a few comments though:

In +void SVGAnimateElement::applyAnimatedValueToElement(unsigned repeat)

"valueToApple" seems like it may be a tyop :D

I suspect parseNumberValueAndUnit will parse "100 px/%" etc which seems bogus

Adding commented out code in SVGAnimateMotionElement::parseMappedAttributes
seems like an accident, and isn't commented itself so i have no idea why :(

Tyop in m_baseIndexInTranformList -- missing 's'

Are you sure about the comment in SVGElement::updateStyleAttributeIfNeeded?
i've seen plenty of examples of people using "style" attributes in svg, it
seems odd for it to not be accessible form the dom...

I'm not happy with doubleSort/sortTimeList.  doubleSort makes an assumption
that each m_beginTime will always be the first member of SMILTime which seems
really icky...

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list