[Webkit-unassigned] [Bug 17129] XML ProcessingInstructions do not support title= or alternate= attributes

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17129





------- Comment #6 from rwlbuis at gmail.com  2008-04-05 13:47 PDT -------
Hi Eric,

(In reply to comment #5)
> (From update of attachment 20353 [edit])
> Oh, one style comment.
> 
> single line ifs, the contents should be on the second line:
> if (foo) return;
> should be:
> if (foo)
>     return;
> 
> Also, if you're going to use:
> if (foo != true) instead of the normal if (!foo) for that case, then you should
> use:
> if (foo !== true) to actually check the type returned.  Otherwise:
> if (foo) or if (!foo) is doing the same thing and should be used instead.

Oops, I saw this only after my commit. I assume that was code from the
testcase(s). Let me know if it needs fixing in a new commit.
Cheers,

Rob.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.