[Webkit-unassigned] [Bug 18281] [GTK] add functions to set/get the zoom level

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18281





------- Comment #4 from christian at imendio.com  2008-04-04 08:20 PDT -------
(From update of attachment 20330)
Nice to see some progress here. Now for my first impression:

>+static const gfloat minimumZoomMultiplier = 0.5f;
>+static const gfloat maximumZoomMultiplier = 3.0f;
>+static const gfloat zoomMultiplierRatio = 1.2f;

Where do these values come from? I would hesitate hardcoding anything like that
without good reasing since this what determines good choices can vary much
depending on the device and display in use.

>+WEBKIT_API gfloat
>+webkit_web_view_get_text_size_multiplier (WebKitWebView* webView);
>+
>+WEBKIT_API void
>+webkit_web_view_set_text_size_multiplier (WebKitWebView* webView, gfloat multiplier);

I don't recognize from 'multiplier' anywhere else. 'scale' is familiar term to
describe this.

>+WEBKIT_API gboolean
>+webkit_web_view_can_make_text_larger (WebKitWebView* webView);
>+
>+WEBKIT_API void
>+webkit_web_view_make_text_larger (WebKitWebView* webView);
>+
>+WEBKIT_API gboolean
>+webkit_web_view_can_make_text_smaller (WebKitWebView* webView);
>+
>+WEBKIT_API void
>+webkit_web_view_make_text_smaller (WebKitWebView* webView);
>+
>+WEBKIT_API gboolean
>+webkit_web_view_can_make_text_standard_size (WebKitWebView* webView);
>+
>+WEBKIT_API void
>+webkit_web_view_make_text_standard_size (WebKitWebView* webView);

This terminology makes no sense other than in an OS X application. However
reseting the text size multiplier seems useful functionality wise.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.