[Webkit-unassigned] [Bug 17952] Add "--cairo" flag to 'build-webkit' command

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 2 02:43:55 PDT 2008


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #19887|review?                     |review-
               Flag|                            |

------- Comment #4 from darin at apple.com  2008-04-02 02:43 PDT -------
(From update of attachment 19887)
+    if (checkArgv("--cairo")) {
+        $isCairo = 1;
+    } else {
+        $isWx = 0;
+    }

Seems wrong to set $isWx here.

But also, I think you'd want this setting to be a persistent one. It seems
really inconvenient to have to pass --cairo every single time. It should work
more like configuration where you can set it once and then it's persistent
until you reset it.

review- because of the $isWx mistake, but please consider my suggestion.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list