[Webkit-unassigned] [Bug 15299] GTK: ChromeClientGtk.cpp does not implement mouseDidMoveOverElement()

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15299


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16459|review?                     |review-
               Flag|                            |




------- Comment #4 from aroben at apple.com  2007-09-29 15:28 PDT -------
(From update of attachment 16459)
+    } else {
+        g_signal_emit_by_name(m_webPage, "hovering_over_link", NULL, NULL);   
+    }

As specified on <http://webkit.org/coding/coding-style.html>, please omit the
braces around the single-line body of the else block. We also use 0 instead of
NULL since this is C++ code.

We normally put the bug title and URL in the ChangeLog entry as well.

This looks great, though! Fix up those things and I'll r+ it.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.