[Webkit-unassigned] [Bug 14126] Shell scripts to build WebKit should be forced to LF endings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 29 14:46:29 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=14126


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16432|review?                     |review-
               Flag|                            |




------- Comment #6 from ddkilzer at webkit.org  2007-09-29 14:46 PDT -------
(From update of attachment 16432)
>@@ -68,6 +68,8 @@ while (<IN>) {
>     chomp;
>     my $prop = $_;
> 
>+	$prop =~ s/[\r\n]+$//;

The chomp statement isn't necessary with the added line.  (Sorry, I should have
caught this with the first review.)

Please remove the chomp statement, repost the patch, and r=me.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list