[Webkit-unassigned] [Bug 15299] GTK: ChromeClientGtk.cpp does not implement mouseDidMoveOverElement()

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15299


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16418|review?                     |review-
               Flag|                            |




------- Comment #2 from aroben at apple.com  2007-09-28 12:06 PDT -------
(From update of attachment 16418)
I think it would be nicer to return early if url.isEmpty() is true instead of
nesting the entire function inside the if.

Your patch contains tabs, which will be disallowed by our pre-commit hook.
Please use indents of 4 spaces instead of tabs. See
<http://webkit.org/coding/coding-style.html>

Your patch needs a ChangeLog. See <http://webkit.org/coding/contributing.html>
for how to create one.

Thanks for the patch!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.