[Webkit-unassigned] [Bug 15212] Useless checking for Item in FrameLoader::goBackOrForward(int distance)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 26 02:31:24 PDT 2007


mbritto at pleyo.com changed:

           What    |Removed                     |Added
  Attachment #16290|review?                     |
               Flag|                            |
  Attachment #16290|0                           |1
        is obsolete|                            |
  Attachment #16397|                            |review?
               Flag|                            |

------- Comment #2 from mbritto at pleyo.com  2007-09-26 02:31 PDT -------
Created an attachment (id=16397)
 --> (http://bugs.webkit.org/attachment.cgi?id=16397&action=view)
modified patch

After the talk mitzpettel and I had, we decided to let the check for the
reachable item in the function because it's more conveniant for the future
Though I added an assert to help future debug.
I let that last check to avoid an eventually crash on release versions :
    if (item)
        page->goToItem(item, FrameLoadTypeIndexedBackForward);

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list