[Webkit-unassigned] [Bug 15255] GTK+ WebKit should allow the application to execute Javascript on it.

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15255





------- Comment #13 from freyther at handhelds.org  2007-09-23 14:16 PDT -------
(In reply to comment #5)
> Created an attachment (id=16350)
 --> (http://bugs.webkit.org/attachment.cgi?id=16350&action=view) [edit]

As Adam pointed out I have one question/concern/remark.
executeScript(WebCore::String, bool) gets invoked with executeScript(const
gchar*, bool), this means auto-boxing is going to take place.

Now WebCore::String (WebCore/platform/PlatformString.h) will not do any charset
conversion. So only ascii/latin1 is a valid input. I think we should follow
Gtk+ examples and make all strings utf-8. So I propose adding a
String::fromUtf8 around the script parameter.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.