[Webkit-unassigned] [Bug 15254] [gtk] implement theme-aware drawing of text field or text area

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 22 13:24:53 PDT 2007


aroben at apple.com changed:

           What    |Removed                     |Added
  Attachment #16344|review?                     |review-
               Flag|                            |

------- Comment #2 from aroben at apple.com  2007-09-22 13:24 PDT -------
(From update of attachment 16344)
+    else if (isChecked(o))
+        result = GTK_STATE_SELECTED;

Is this really needed for drawing text fields? Or is this just something that
was missing and you added it while you were touching the code?

+    gtk_paint_shadow(entry->style, i.context->gdkDrawable(),
+                     determineState(o), determineShadow(o),
+                     NULL, entry, "entry",
+                     pos.x(), pos.y(), rect.width(), rect.height());

Since this is C++ code, please use 0 instead of NULL.

+    if (GTK_WIDGET_HAS_FOCUS(entry))
+    {

As per <http://webkit.org/coding/coding-style.html>, please pur the brace on
the same line as the if.

r- so the above can be fixed. Once that's done I'll r+ it.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list