[Webkit-unassigned] [Bug 15255] GTK+ WebKit should allow the application to execute Javascript on it.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 22 13:21:20 PDT 2007


aroben at apple.com changed:

           What    |Removed                     |Added
  Attachment #16347|review?                     |review-
               Flag|                            |

------- Comment #4 from aroben at apple.com  2007-09-22 13:21 PDT -------
(From update of attachment 16347)
As per <http://webkit.org/coding/coding-style.html>, please put asterisks next
to the type name, not the variable name.

+    if (FrameLoader *loader = frameData->frame->loader())
+        loader->executeScript(script, true);

Looks like you've got an extra line of whitespace after the if statement.

I also think it would make more sense for this API to be on WebKitGtkFrame,
rather than having it implicitly operate on the main frame.

r- for now so that the above changes can be made, but I definitely agree this
is a useful API to have!

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list