[Webkit-unassigned] [Bug 15229] [gtk] abstract font management by using pango

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15229





------- Comment #3 from mrowe at apple.com  2007-09-21 06:26 PDT -------
(From update of attachment 16339)
I didn't look very closely at the actual code in the patch as I'm not
particularly familiar with font handling in WebCore, but I will point out a few
areas in which the code doesn't match the WebKit style guidelines
(<http://webkit.org/coding/coding-style.html>).

* Many newly-added function calls have unneeded whitespace between the function
name and the opening parenthesis.

* There are several places where you have extra whitespace around, or incorrect
placement of, the * in declarations of pointer variables.  In several places
you have extra whitespace around the = operator in assignments.  More
generally, we don't typically use whitespace to line up assignments and
declarations.

* In several places you have broken function calls across multiple lines for no
apparent reason.  In cases where it's wrapped due to one argument being the
result of a function call, it may be preferable to use a local variable to
simplify the code rather than jamming it all into the function call.  In other
cases, having all the arguments on the same line may be preferable.

* When checking if a pointer is NULL, !theVariable is preferred over
theVariable == 0.

* Declaring local variables at the point of first use is preferred over
declaring at the top of a function then initializing later.


Sorry for being so picky!  Hopefully someone can review the real meat of your
patch soon.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.