[Webkit-unassigned] [Bug 15223] webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 18 13:28:45 PDT 2007


aroben at apple.com changed:

           What    |Removed                     |Added
  Attachment #16313|review?                     |review-
               Flag|                            |

------- Comment #6 from aroben at apple.com  2007-09-18 13:28 PDT -------
(From update of attachment 16313)
+sub determineIsGdk ()

Please remove the space before the parentheses.

+        if (defined($platformParameter)) {
+            $buildResult = system "WebKitTools/Scripts/build-dumprendertree",
$configurationOption, $platformParameter;
+        } else {
+            $buildResult = system "WebKitTools/Scripts/build-dumprendertree",
+        }

You don't need to check defined($platformParameter) here. You can just pass it
to system, since passing undef is the same as not passing anything at all.

Thanks for all the fixes so far!

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list