[Webkit-unassigned] [Bug 15228] Missing flex, bison, or gperf produces a failing build

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15228


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16309|review?                     |review-
               Flag|                            |




------- Comment #2 from ddkilzer at webkit.org  2007-09-18 09:48 PDT -------
(From update of attachment 16309)
>+    } elsif (isGdk() or isQt()) {
>+        my @cmds = qw(flex bison gperf);
>+        foreach my $cmd (@cmds) {
>+            if (not `$cmd --version`) {
>+                die ((join ", ", @cmds) . " required to build WebKit.\n");
>+            }
>+        }
>     }

Thanks for taking the time to file a bug and create a patch!  This looks good,
but I'd like to see the code changed to test for all three commands and report
only the ones that are missing.

For example if flex and bison are installed but not gperf, the developer gets a
message about all three being required to build instead of a message about
"gperf" missing.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.