[Webkit-unassigned] [Bug 15223] webkitdir.pm::isQt() is not working properly in run-webbkit-test under Linux/Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 17 22:22:16 PDT 2007


aroben at apple.com changed:

           What    |Removed                     |Added
  Attachment #16302|review?                     |review-
               Flag|                            |

------- Comment #4 from aroben at apple.com  2007-09-17 22:22 PDT -------
(From update of attachment 16302)
-    } else { 
-        $buildResult = system "WebKitTools/Scripts/build-dumprendertree",
+    #On linux, we give the platform to build-dumprendertree as a parameter
+    } elsif (isQt()) {
+        $buildResult = system "WebKitTools/Scripts/build-dumprendertree",
$configurationOption, "--qt";
+    } elsif (isGdk()) {
+        $buildResult = system "WebKitTools/Scripts/build-dumprendertree",
$configurationOption, "--gdk";

A couple of comments here:
1) It looks like you've broken this script on OS X here because there's no case
that OS X would fall into now (before it fell into the else).
2) I think it would be nice to store the final argument in a variable so that
we don't need all these elsifs. This would also solve problem number (1).

+sub determineIsQt() {

We normally put the opening brace of a function on its own line.

+sub determineIsGdk () {

Ditto, and we don't put a space before the ().

Overall, this looks great, but r- so that we can fix this on OS X and these
small style issues.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list