[Webkit-unassigned] [Bug 15221] Make the FileSystemChooserGdk implementation properly convert the WebCore::String presentation

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15221


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16297|review?                     |review-
               Flag|                            |




------- Comment #2 from aroben at apple.com  2007-09-16 13:16 PDT -------
(From update of attachment 16297)
+                gchar* basename = g_filename_to_utf8(basenameSystem, -1, 0, 0,
0);
+                g_free(basenameSystem);
+
+                if (basename) {
+                    string = String::fromUTF8(basename);
+                    g_free(basename);
+                }

This sequence should be factored out into a static helper function instead of
repeating it twice in this file. Otherwise looks good.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.