[Webkit-unassigned] [Bug 15177] [gtk] FontPlatformData contains more fields than required

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 08:03:11 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=15177


mrowe at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16254|review?                     |review+
               Flag|                            |




------- Comment #7 from mrowe at apple.com  2007-09-11 08:03 PDT -------
(From update of attachment 16254)
Some minor comments:
The local variables inside FontPlatformData::FontPlatformData should lose the
m_ prefix, which is used only for members.  I think the declarations can be
moved to their point of first use too.
Our coding style also requires no space between the function name and it's
arguments.

I'll make those minor tweaks when I land this.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list