[Webkit-unassigned] [Bug 15177] New: [gtk] FontPlatformData contains more fields than required

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15177

           Summary: [gtk] FontPlatformData contains more fields than
                    required
           Product: WebKit
           Version: 522+ (nightly)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: sven at imendio.com


FontPlatformData::setFont(cairo_t*) can be changed to use m_scaledFont
directly. This makes the function easier readable and still works exactly as
expected.

m_fontFace, m_fontMatrix, and m_options are used in the main constructor in
FontPlatformDataGdk.cpp only then. So they should be turned into local
variables instead of extra fields.

The attached patch-set reduces the memory footprint of each FontPlatformData by
3*sizeof(void*).

The only issue that's left is that the former fields are not renamed according
the the code conventions in my patches, do you want another patch for that?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.