[Webkit-unassigned] [Bug 15176] run-launcher overwrites LD_LIBRARY_PATH

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15176


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16249|                            |review-
               Flag|                            |




------- Comment #4 from ddkilzer at webkit.org  2007-09-11 06:52 PDT -------
(From update of attachment 16249)
Using $ENV{LD_LIBRARY_PATH} without checking to see if it's set will cause a
"Use of uninitialized value" warning to be printed in the case where it's not
set.  You should do something like:

$ENV{LD_LIBRARY_PATH} = $ENV{LD_LIBRARY_PATH} ?
"$productDir:$ENV{LD_LIBRARY_PATH}" : $productDir;

Setting review- flag to fix this issue.

Please set the "review?" flag on patches in the future if you'd like them to be
reviewed.  (There is no need to set a email address with the review flag.)

Also, please create a ChangeLog entry with the patch.  (The description you
have in your git commit message is great!)

http://webkit.org/coding/contributing.html

Thanks for reporting this bug!


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.