[Webkit-unassigned] [Bug 15148] Poor performance on crazy DOM raytracer

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15148


catfish.man at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16206|0                           |1
        is obsolete|                            |
  Attachment #16229|                            |review?
               Flag|                            |




------- Comment #4 from catfish.man at gmail.com  2007-09-08 14:47 PDT -------
Created an attachment (id=16229)
 --> (http://bugs.webkit.org/attachment.cgi?id=16229&action=view)
Addresses review comments

>This seems like a gratuitous change:
>
>-        for ( ; (r = it.current()); ++it) {
>+        for ( ; (r = it.current()); ++it ) {

Oops, leftover from a find & replace style fixup. Fixed.

>There's no need to use new here, you can just make the Vector a local variable:
>
>+    Vector<RenderObject*>* deadObjects = new Vector<RenderObject*>();
>
>In fact, it might be worthwhile giving it an inline capacity to handle the
>common case effeciently. Something like:
>
>Vector<RenderObject*, 16> deadObjects;

Fixed.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.