[Webkit-unassigned] [Bug 14998] Full page zooming support

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14998


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16217|review?                     |review-
               Flag|                            |




------- Comment #16 from oliver at apple.com  2007-09-07 12:52 PDT -------
(From update of attachment 16217)
style issues:
+    webkit_gtk_page_set_scale_factor(gPage, scaleFactor * 1.2);
..
+    webkit_gtk_page_set_scale_factor(gPage, scaleFactor / 1.2);

However i'd prefer a integer representing the scale level, which you then
modified, eg:
+static void menuMainZoomInCallback(gpointer)
+{
+    if (scaleFactor < 10)
+        scaleFactor++;
+    webkit_gtk_page_set_scale_factor(gPage, scaleFactor * whatever);
+}
+
+static void menuMainZoomOutCallback(gpointer)
+{
+    if (scaleFactor > 0)
+        scaleFactor--;
+    webkit_gtk_page_set_scale_factor(gPage, scaleFactor * whatever);
+}

Which would mean that you wouldn't get cumulative rounding error over time.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.