[Webkit-unassigned] [Bug 14868] Import variable lookup optimizations from KJS

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14868


cwzwarich at uwaterloo.ca changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16203|review?                     |
               Flag|                            |
  Attachment #16203|0                           |1
        is obsolete|                            |
  Attachment #16215|                            |review?
               Flag|                            |




------- Comment #12 from cwzwarich at uwaterloo.ca  2007-09-07 07:05 PDT -------
Created an attachment (id=16215)
 --> (http://bugs.webkit.org/attachment.cgi?id=16215&action=view)
Revised proposed patch

Here's a revised patch. It has the following differences:

- it now patches cleanly against ToT.
- I cleaned up some style problems, like a few ASSERT usages that I somehow
missed
- I added test cases for the direct write bugs. The array one wouldn't actually
fail for any version of the code, because AssignBracketNode doesn't do direct
writes.

I hope I didn't miss anything. There is only one bad thing of which I am aware.
When I run the entirety of the layout tests or just fast/dom,
fast/dom/constructors-overriding.html will sometimes crash, but I can't get it
to crash on its own. The crash is in ActivationImp::mark(), which is modified
by this patch. It doesn't seem to crash without the patch (I didn't try on my
machine, I am just going by the build bot and Mark).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.