[Webkit-unassigned] [Bug 15749] New: RegExp/RegExpObjectImp cause needless UString creation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 29 02:45:39 PDT 2007


           Summary: RegExp/RegExpObjectImp cause needless UString creation
           Product: WebKit
           Version: 523.x+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: mjs at apple.com, darin at apple.com, oliver at apple.com

RegExp/RegExpObjectImp cause needless UString creation

performMatch/match return a UString, which is only used by very few callers
(and I'm not sure those are even necessary).  Instead it just needs to return
the size of the match.  if the size is non-zero, then there was a match (what
most callers care about) and the callers which care about the size have that
too.  There are a couple cases (replacement) where we need to actually be able
to generate the match string, but that can be done using the returned offset
vector and some sort of helper function.  I expect this will be a couple
percentage points speedup, due to the reduce malloc pressure.

I'm too tired to write it (and busy much of tomorrow).  Anyone who feels the
urge should feel free.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list