[Webkit-unassigned] [Bug 15682] Move wx port to TOT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 25 08:42:51 PDT 2007


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
                 CC|                            |mjs at apple.com,
                   |                            |darin at apple.com
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

------- Comment #3 from ddkilzer at webkit.org  2007-10-25 08:42 PDT -------
(In reply to comment #0)
> I think it's time to finally move wxWebKit over to TOT. I'm submitting the port
> as one big patch to make it easy to apply and to ensure it doesn't negatively
> affect other ports, but of course I can rework the patch if someone has a
> better suggestion. [...]

I think it would be easier to review this patch in smaller "logical" chunks. 
No need to create separate Bugzilla bugs for this, just attach them here and
clear the review flags as they're landed.

Some random thoughts:

- All the casting changes to cross-platform files required to make the Wx port
build could be put in their own patch.
- Any code that otherwise touches cross-platform files should be put in their
own patches (grouped by what they fix).
- All changes to Wx-specific files (including new files) could be bundled in
their own patch since the only thing being reviewed there is style and
(perhaps) architecture.
- The Python bindings code (especially WebKit/wx/bindings/python/webview.cpp)
could be it's own patch (it's HUGE--about 1/3 to 1/2 of the current patch :)!
- Should WebKit/wx/.bakefile_gen.state be included in the patch (or be checked
into the repository)?  That seems like it may be a build-time Bakefile

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list