[Webkit-unassigned] [Bug 15633] SunSpider shows JSC spending time in KJSCHECKEXCEPTIONVALUE

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15633





------- Comment #8 from eric at webkit.org  2007-10-24 15:32 PDT -------
Ok, so I've further revised my theory for how we can remove all these if
(exec-hadException()) checks.  Like before, we make exec->setException() ASSERT
when already had an exception.  We remove *all* exception checks, except before
any user-visible change.  User visible changes come in 3 flavors:
1.  Assignment nodes (we have to pretend execution stopped immediately after
the exception, make sure it stops before we change any variable)
2.  Loops (hanging due to assignments never happening, thus loops never
reaching their termination condition is a bad thing, loops need to check
exceptions)
3.  non-source function calls (functions provided by the interpreter must not
be called after an exception).

Otherwise execution can continue willie-nilly until we decide to stop at a
convenient time.  SourceElementsNode (for example) should probably check
exceptions in its loop just to make sure we don't continue on too far.

Sound totally crazy?  Or just crazy enough... ;)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.