[Webkit-unassigned] [Bug 15646] New: [GTK] caretBlinkFrequency is hard-coded in Frame.cpp

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15646

           Summary: [GTK] caretBlinkFrequency is hard-coded in Frame.cpp
           Product: WebKit
           Version: 523.x+ (nightly)
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: alp at atoker.com


WebCore/page/Frame.cpp:

static const double caretBlinkFrequency = 0.5;

On GTK+ at least, this is configurable. It can even change while the
application is running, so we need to abstract this setting. It does not,
however, need to be configurable in any public API.

>From gtktextview.c in GTK+:

static gboolean
cursor_blinks (GtkTextView *text_view)
{
  GtkSettings *settings = gtk_widget_get_settings (GTK_WIDGET (text_view));
  gboolean blink;

#ifdef DEBUG_VALIDATION_AND_SCROLLING
  return FALSE;
#endif
  if (gtk_debug_flags & GTK_DEBUG_UPDATES)
    return FALSE;

  g_object_get (settings, "gtk-cursor-blink", &blink, NULL);

  if (!blink)
    return FALSE;

  if (text_view->editable)
    {
      GtkTextMark *insert;
      GtkTextIter iter;

      insert = gtk_text_buffer_get_insert (get_buffer (text_view));
      gtk_text_buffer_get_iter_at_mark (get_buffer (text_view), &iter, insert);

      if (gtk_text_iter_editable (&iter, text_view->editable))
        return blink;
    }

  return FALSE;
}

static gint
get_cursor_time (GtkTextView *text_view)
{
  GtkSettings *settings = gtk_widget_get_settings (GTK_WIDGET (text_view));
  gint time;

  g_object_get (settings, "gtk-cursor-blink-time", &time, NULL);

  return time;
}

static gint
get_cursor_blink_timeout (GtkTextView *text_view)
{
  GtkSettings *settings = gtk_widget_get_settings (GTK_WIDGET (text_view));
  gint time;

  g_object_get (settings, "gtk-cursor-blink-timeout", &time, NULL);

  return time;
}


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.