[Webkit-unassigned] [Bug 15644] New: HTML and SVG need to share more text painting code

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15644

           Summary: HTML and SVG need to share more text painting code
           Product: WebKit
           Version: 523.x+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: zimmermann at kde.org


HTML and SVG need to share more text painting code

I was looking through the SVG text painting code today and I realized that a
good bit of it is just copy/paste.  One glaring example:

    // Set a text shadow if we have one.
    // FIXME: Support multiple shadow effects.  Need more from the CG API
before
    // we can do this.
    bool setShadow = false;
    if (styleToUse->textShadow()) {
        paintInfo.context->setShadow(IntSize(styleToUse->textShadow()->x,
styleToUse->textShadow()->y),
                                     styleToUse->textShadow()->blur,
styleToUse->textShadow()->color);
        setShadow = true;
    }

What happens when the HTML text side finally fixes that bug?  It will be broken
for SVG too, unless we abstract that (and other) logic into a single shared
function.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.