[Webkit-unassigned] [Bug 15642] Report build errors to users on Windows

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15642


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16821|review?                     |review-
               Flag|                            |




------- Comment #2 from aroben at apple.com  2007-10-23 13:12 PDT -------
(From update of attachment 16821)
+    if (1 || exitStatus($result)) {

I assume the "1 ||" was for debugging purposes? In any case I think it should
be removed.

+sub getRelativeScriptsDir()

I don't think the "get" prefix is helpful here.

It would be great at some point to enhance the script to look through the build
logs to figure out which project(s) failed and point the user at those logs
more specifically.

I'll r+ once the above two issues are fixed.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.