[Webkit-unassigned] [Bug 15409] FrameLoaderClientGtk hardcodes data, including platform to Linux i686

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15409


mrowe at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrowe at apple.com




------- Comment #9 from mrowe at apple.com  2007-10-21 16:59 PDT -------
A couple of comments on the patch...  The values returned from uname are not
what you would want when running on the Mac.  They return "Darwin" and "i386"
when the user agent should have "Intel Mac OS X" for consistency with other
browsers.  The WebKit version number really needs to be kept up to date. 
Perhaps it could be based on the most recent version number used on Windows,
which is stored in a plain text file at WebKit/win/WebKit.vcproj/VERSION.

Ideally, IMO, the user agent string should be as similar as possible to the
native Mac and Windows ports when running on those platforms.  For other
platforms, I would suggest comparing looking at precisely which fields Firefox
changes and following their lead.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.