[Webkit-unassigned] [Bug 12159] Most of CSSComputedStyleDeclaration, cssparser.cpp, cssstyleselector.cpp should be autogenerated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 16 23:48:02 PDT 2007


ap at webkit.org changed:

           What    |Removed                     |Added
  Attachment #16692|                            |review?
               Flag|                            |

------- Comment #14 from ap at webkit.org  2007-10-16 23:48 PDT -------
Created an attachment (id=16692)
 --> (http://bugs.webkit.org/attachment.cgi?id=16692&action=view)
updated patch

(In reply to comment #8)

> The checking here seems unnecessary. I think we can just omit it.


> Do we have test cases that cover all the different length types and property
> values?

Hmm, I think the tests in css1/ and css2.1/ cover this.

> I think that needing to do this is quite unfortunate. Because of this, I'm not
> happy with the template conversion technique. Can we switch to a simpler
> technique that doesn't involve templates?

Attached is another attempt to save the template technique :)

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list