[Webkit-unassigned] [Bug 15409] FrameLoaderClientGtk hardcodes data, including platform to Linux i686

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 16 09:39:16 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=15409


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16590|review?(aroben at apple.com)   |review-
               Flag|                            |




------- Comment #6 from aroben at apple.com  2007-10-16 09:39 PDT -------
(From update of attachment 16590)
+    m_userAgent = (WebCore::String)"Mozilla/5.0 (GTK+; " + un.sysname + " " +
un.machine + "; " + g_get_language_names()[0] + ") AppleWebKit/420+ (KHTML,
like Gecko)";

I think it would be better to use String::format() here instead of building
this string by appending.

We should also add a FIXME about getting the version number correct.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list