[Webkit-unassigned] [Bug 15356] getResponseHeader and getAllResponseHeaders do not throw exceptions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 09:19:39 PDT 2007


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #16596|review?                     |review-
               Flag|                            |

------- Comment #8 from darin at apple.com  2007-10-15 09:19 PDT -------
(From update of attachment 16596)
+        // Should raise a SYNTAX_ERR exception
+        // but Opera and IE returns an empty string, so we just return an
empty string

We should get this fixed in the XMLHttpRequest specification if browsers really
can't follow it and be compatible.

Is there really a need to add the isValidToken check? What's the behavior if we
leave it out? Do any of the tests you wrote fail if you leave out the
isValidToken check?

+            //used to call getResponseHeader but could raise unnecessary

I don't think that's a helpful comment. Please just leave it out.

+    String getAllResponseHeaders(ExceptionCode& ec) const;
+    String getResponseHeader(const String& name, ExceptionCode& ec) const;

The argument doesn't need a name in the header (see the setRequestHeader above
for an example of how we write these).

review- mainly because of the isValidToken question

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list