[Webkit-unassigned] [Bug 12159] Most of CSSComputedStyleDeclaration, cssparser.cpp, cssstyleselector.cpp should be autogenerated

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12159


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16667|review?                     |review-
               Flag|                            |




------- Comment #8 from darin at apple.com  2007-10-15 07:43 PDT -------
(From update of attachment 16667)
+            ASSERT(boxAlign != BJUSTIFY);
+            if (boxAlign == BJUSTIFY)
+                return 0;

+            ASSERT(pageBreak != PBALWAYS);
+            if (pageBreak == PBALWAYS)
+                return 0;

The checking here seems unnecessary. I think we can just omit it.

Do we have test cases that cover all the different length types and property
values?

-        CSSPrimitiveValue* val = new CSSPrimitiveValue(pair);
+        CSSPrimitiveValue* val = new
CSSPrimitiveValue(PassRefPtr<Pair>(pair));

I think that needing to do this is quite unfortunate. Because of this, I'm not
happy with the template conversion technique. Can we switch to a simpler
technique that doesn't involve templates?

We could just put all the enums into a separate header file and use plain old
overloading.

I otherwise think this is cool, and a great direction.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.