[Webkit-unassigned] [Bug 12159] Most of CSSComputedStyleDeclaration, cssparser.cpp, cssstyleselector.cpp should be autogenerated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 14 08:11:47 PDT 2007


ap at webkit.org changed:

           What    |Removed                     |Added
  Attachment #16667|                            |review?
               Flag|                            |

------- Comment #7 from ap at webkit.org  2007-10-14 08:11 PDT -------
Created an attachment (id=16667)
 --> (http://bugs.webkit.org/attachment.cgi?id=16667&action=view)
Move enum mapping into a separate file

This patch is IMHO helpful regardless of whether we decide to auto-generate any
more code.

The CSSComputedStyleDeclaration part is pretty straightforward. In
CSSStyleSelector, there was some error checking I don't quite understand,
especially because not all cases have it. I might have removed something
important, or kept something unnecessary.

-        if (!primitiveValue || !primitiveValue->getIdent())
-            return;
-    if (!value->isPrimitiveValue()) return;

It seems that these are guaranteed by the parser. Similarly, some checks for
unexpected ident values may have changed, but it doesn't seem that they
actually come into play unless memory is overwritten.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list