[Webkit-unassigned] [Bug 12159] Most of CSSComputedStyleDeclaration, cssparser.cpp, cssstyleselector.cpp should be autogenerated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 9 12:48:33 PDT 2007


------- Comment #4 from ap at webkit.org  2007-10-09 12:48 PDT -------
I think that a lot of ugly code can be eliminated by moving enum mapping to
CSSPrimitiveValue. E.g.

            switch (style->resize()) {
                case RESIZE_BOTH:
                    return new CSSPrimitiveValue(CSS_VAL_BOTH);
                case RESIZE_HORIZONTAL:
                    return new CSSPrimitiveValue(CSS_VAL_HORIZONTAL);
                case RESIZE_VERTICAL:
                    return new CSSPrimitiveValue(CSS_VAL_VERTICAL);
                case RESIZE_NONE:
                    return new CSSPrimitiveValue(CSS_VAL_NONE);

could hopefully become

            return new CSSPrimitiveValue(style->resize());

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list