[Webkit-unassigned] [Bug 14206] MSVC7 support and PLATFORM define fixes for Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 7 13:58:25 PDT 2007


kevino at theolliviers.com changed:

           What    |Removed                     |Added
  Attachment #16561|0                           |1
        is obsolete|                            |
  Attachment #16577|                            |review-
               Flag|                            |

------- Comment #7 from kevino at theolliviers.com  2007-10-07 13:58 PDT -------
Created an attachment (id=16577)
 --> (http://bugs.webkit.org/attachment.cgi?id=16577&action=view)
Patch with Adam Roben's changes

Thanks for taking a look at this! I think you're right that the debugger code
should be checking for the MSVC compiler. Whether or not the code can compile
in other environments (which I'm not sure about either), it's only useful when
you plan to use it with the Visual Studio IDE anyway, so I think it's best to
define it this way. As for vsnprintf, they weren't the same in previous
iterations which is why I had separate functions. I just didn't pay attention
to the fact that my recent changes made them the same. :-)

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list