[Webkit-unassigned] [Bug 15299] GTK: ChromeClientGtk.cpp does not implement mouseDidMoveOverElement()

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15299


jmalonzo at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16542|review?                     |
               Flag|                            |
  Attachment #16542|0                           |1
        is obsolete|                            |
  Attachment #16569|                            |review?
               Flag|                            |




------- Comment #21 from jmalonzo at gmail.com  2007-10-06 16:42 PDT -------
Created an attachment (id=16569)
 --> (http://bugs.webkit.org/attachment.cgi?id=16569&action=view)
Fix signal not emitted when hovering on links in succession - update

> (In reply to comment #17)
> +    , m_hoveredLink(0)
> 
> KURL will be automatically initialized. So this is not needed/wanted. I wonder
> what will happen in the following case:

Fixed in the updated patch.

> Currently you get a signal with NULL, NULL when leaving a link, when you switch
> from one to another URL you will not get such a signal. Is that a semantic
> issue? Do we at least want to document this?

As long as we document it, it shouldn't be an issue. I thought the signal was
just a hint that we hovered out on a link. Any suggestions?

> I also wonder if we need
> m_didSendLinkSignal at all. We can just compare the URLs.

The updated patch removes m_didSendLinkSignal and just checks for differences
between current and previously hovered link.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.