[Webkit-unassigned] [Bug 15394] New: notifyAttributeChanged should be removed (or at least reduced in usage)

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15394

           Summary: notifyAttributeChanged should be removed (or at least
                    reduced in usage)
           Product: WebKit
           Version: 522+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: zimmermann at kde.org


notifyAttributeChanged should be removed (or at least reduced in usage)

Currently modifying any attribute on an SVGStyledElement will cause that
element to relayout.  This is bad.  Very bad.

This is due to the evil "notifyAttributeChanged" function which
indiscriminately calls renderer()->setNeedsLayout() w/o first checking what
attribute might be changed (or allowing other parsing machinery to see if the
resulting new value is actually different from the previous one.

notifyAttributeChanged (i'm told) may need to exist to support SVG "tear off"
javascript bindings. I'm not 100% convinced of that.  Regardless,
notifyAttributeChanged can be removed from attributeChanged and the appropriate
places in the code currently depending on the nAC call cleaned up.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.