[Webkit-unassigned] [Bug 15080] <use> element not refresh after adding objects by script in referrer

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15080





------- Comment #6 from rwlbuis at gmail.com  2007-10-06 00:06 PDT -------
Hi,

(In reply to comment #5)
> (From update of attachment 16550 [edit])
> +    if (ownerDocument()->parsing())
> +        return;
> 
> Please use document(). ownerDocument() is just a slower way to call document()
> that returns 0 in the special case of a Document node.

Ok, will do. I'll also change the other spots where we use them, but in a
separate patch.

> Why is it OK to skip updateElementInstance if parsing is true? What guarantees
> it's called later?

Since addChild is not used, every append triggers a childrenChanged while
parsing. However, the related shadow tree is only built later when the <use>
is processed, and <use> needs a referenced tree that is fully build anyway. The
only phase we didnt cover is dynamic addition and that is what this patch
fixes. I hope that clears it up.
Cheers,

Rob.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.