[Webkit-unassigned] [Bug 15359] JPEG image not shown when height is specified as percentage inside a table

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15359


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16536|                            |review?
               Flag|                            |




------- Comment #5 from ddkilzer at webkit.org  2007-10-04 09:47 PDT -------
Created an attachment (id=16536)
 --> (http://bugs.webkit.org/attachment.cgi?id=16536&action=view)
Hack v1

This is a hack that will allow the image to be display correctly within the
table (e.g., it displays the same as if the table were removed from the test). 
I'm setting the review flag to see if this is the correct approach.

Note that because of what isHeightSpecified() checks, this change in
RenderImage::calcReplacedHeight():

+    if (isHeightSpecified() && style()->height().type() != Percent)

could really just be:

+    if (style()->height().type() == Fixed)

If this is not the correct approach, then I'd guess that
RenderBox::calcReplacedHeightUsing() needs to be taught how to use
instrinsicSize() for <img> tags.  (Am I in the ballpark here? :)

Layout tests running now with this change to check for any failures.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.